Support drivers and sources in job-configuration schema #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (76.25%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. @@ Coverage Diff @@
## main #195 +/- ##
==========================================
+ Coverage 76.09% 76.25% +0.15%
==========================================
Files 124 124
Lines 2719 2737 +18
Branches 469 472 +3
==========================================
+ Hits 2069 2087 +18
Misses 453 453
Partials 197 197
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
knoepfel
changed the title
knoepfel
changed the title
knoepfel
force-pushed
the
json-schema
branch
2 times, most recently
from
da147c6 to
68ca382
Compare
knoepfel
force-pushed
the
json-schema
branch
from
68ca382 to
5ec9d63
Compare
knoepfel
force-pushed
the
json-schema
branch
from
5ec9d63 to
df55843
Compare
Also make 'sources' optional at the job-configuration schema level
marcpaterno
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enforces the schema:
{ driver: { # Single table of configuration for plugin that registers a driver # ... # N.B. Prototype 0.1 will not support an API for user-definable drivers # Prototype 0.1 includes the 'generate_layers' driver plugin }, sources: { # Table of configurations for plugins that register providers # ... }, modules: { # Table of configurations for modules that register physics algorithms # ... }, }Closes #106.